Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of f4d57f9b710de20c7cf04c8ab07e3af7c577a5c1 #35

Closed
kkebo opened this issue Oct 14, 2024 · 3 comments · Fixed by #43
Closed

Rework of f4d57f9b710de20c7cf04c8ab07e3af7c577a5c1 #35

kkebo opened this issue Oct 14, 2024 · 3 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request

Comments

@kkebo
Copy link
Owner

kkebo commented Oct 14, 2024

Rework of f4d57f9 is needed.

Originally posted by @kkebo in #34 (comment)

@kkebo kkebo self-assigned this Oct 14, 2024
@kkebo kkebo added the enhancement New feature or request label Oct 14, 2024
kkebo added a commit that referenced this issue Oct 14, 2024
@kkebo
Copy link
Owner Author

kkebo commented Oct 20, 2024

I tried to:

  • remove @_optimize(none) from Framebuffer.init()
    • Real device: not work
    • QEMU: work
  • change from @_optimize(none) to @inline(never)
    • Real device: not work
    • QEMU: work
  • use Framebuffer(...) instead of Framebuffer.shared in kmain()
    • Real device: not work work
    • QEMU: work
  • remove @_optimize(none) from Framebuffer.init(), and use Framebuffer(...) instead of Framebuffer.shared in kmain()
    • QEMU: not work
  • change from @_optimize(none) to @inline(never), and use Framebuffer(...) instead of Framebuffer.shared in kmain()
    • QEMU: not work
  • remove -Xswiftc -Osize --experimental-lto-mode=full -Xswiftc -experimental-hermetic-seal-at-link from swift build
    • Real device: not work
    • QEMU: work
  • remove @_optimize(none) from Framebuffer.init(), use Framebuffer(...) instead of Framebuffer.shared in kmain(), and remove all arguments from Framebuffer.init()
    • Real device: work
    • QEMU: work

@kkebo
Copy link
Owner Author

kkebo commented Oct 27, 2024

use Framebuffer(...) instead of Framebuffer.shared in kmain()

This worked on the real device. #40

@kkebo
Copy link
Owner Author

kkebo commented Oct 27, 2024

I previously thought that I should use a singleton for Framebuffer because mboxCall() must be called only once. However, there are other methods that can achieve it. Moreover, there is the disadvantage that parameters cannot be passed from the outside.

So I have decided not to use a singleton.

kkebo added a commit that referenced this issue Oct 27, 2024
kkebo added a commit that referenced this issue Nov 2, 2024
@kkebo kkebo closed this as completed in #43 Nov 5, 2024
@kkebo kkebo closed this as completed in 1464e52 Nov 5, 2024
kkebo added a commit that referenced this issue Nov 5, 2024
chore: do not use `Framebuffer.shared` forever
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant