Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require #:duct.reitit/logging{:enable true} #17

Open
kkharji opened this issue Jan 12, 2022 · 0 comments
Open

Don't require #:duct.reitit/logging{:enable true} #17

kkharji opened this issue Jan 12, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kkharji
Copy link
Owner

kkharji commented Jan 12, 2022

When enable is false, (not nil) then disable logging totally, otherwise, depended on other keys.

Spent few minutes debugging why I'm not getting coercion errors, while at the same time getting request logs and it turned out that defaults:

  :duct.reitit/logging
  {:level :report
   :exceptions? true
   :pretty? true
   :coercions? true
   :requests? true}

doesn't include enable.

Therefore, when and only when enable is false, then overwrite and disable everything.

@kkharji kkharji added the bug Something isn't working label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant