Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yr_weather response from library #2

Open
kmgrime opened this issue Oct 10, 2023 · 2 comments
Open

yr_weather response from library #2

kmgrime opened this issue Oct 10, 2023 · 2 comments
Labels
bug Something isn't working hacktoberfest Hacktoberfest help

Comments

@kmgrime
Copy link
Owner

kmgrime commented Oct 10, 2023

  • The response is not working properly and needs some work to return weather on e.g !weather oslo

lib: https://pypi.org/project/yr-weather/

@kmgrime kmgrime added bug Something isn't working hacktoberfest Hacktoberfest help labels Oct 10, 2023
@ZeroWave022
Copy link

Hi! I'm the author of the library you've mentioned and I've noticed your repo was one that used yr-weather.

I'm finally done writing the next version of the package (0.4.0) which should make some of the functionality easier to code. Feel free to check out the full changelog.

Based on what you already have in responses.py, you could for example just check if the user requested a location that you actually have available in the forecast that you received from the API. The fact that an area is listed in all the possible areas that the API can give you, doesn't mean you have it available. An example of this is shown in the changelog example, and documented here.

If you have any questions or if any issues arise when using the library, feel free to @ me :)

@kmgrime
Copy link
Owner Author

kmgrime commented Oct 16, 2023

Hi! I'm the author of the library you've mentioned and I've noticed your repo was one that used yr-weather.

I'm finally done writing the next version of the package (0.4.0) which should make some of the functionality easier to code. Feel free to check out the full changelog.

Based on what you already have in responses.py, you could for example just check if the user requested a location that you actually have available in the forecast that you received from the API. The fact that an area is listed in all the possible areas that the API can give you, doesn't mean you have it available. An example of this is shown in the changelog example, and documented here.

If you have any questions or if any issues arise when using the library, feel free to @ me :)

Hi @ZeroWave022 !
Fantastic, this will probably make it so much easier to use the lib :D I will defently check out the new docs and continue to work a little on this sideproject of mine. This will defently help - thanks alot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Hacktoberfest help
Projects
None yet
Development

No branches or pull requests

2 participants