Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working outside LAN connections #18

Open
juliangorge opened this issue Jul 10, 2023 · 3 comments
Open

Not working outside LAN connections #18

juliangorge opened this issue Jul 10, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@juliangorge
Copy link

Hello @kmturley !
I really appreciate your time in this project. I have been trying to build a docker image to use it in AWS EC2 instance (also to make compatible with those libraries versions, etc). With no-changes applied in code, I deployed it and successfully connected with devices inside the same LAN net, but when I try to listen a "remote" broadcast, I don't receive any error or message or signal.

I could find what exactly is wrong, and I will be so grateful if you can give me one hand.

Regards!

@kmturley kmturley self-assigned this Jul 10, 2023
@kmturley kmturley added enhancement New feature or request question Further information is requested labels Jul 10, 2023
@kmturley
Copy link
Owner

Hello,
Thanks for trying out my prototype. As mentioned in the README, I only tested it on local networks. It was out-of-scope of the project to also have a hosted version.

However in theory you should be able to get it to work. Key things to check/configure:

  • Check both https:// and ws:// protocols are supported
  • Check the port 8080 allows traffic
  • Check console logs on both client and server to see which events are being fired

@juliangorge
Copy link
Author

Hello Kim, you do not know how I appreciate your time in your response.

Actually, I checked these 1-2 bullet points, but I can not understand how to debug client and server functionality. Although I will continue trying to.
I think it need ICE (Stun and TURN) settings to work fine across any device/NAT/Firewall configuration. Do you consider add it for a new release? :)

Again, thank you for your time.
Regards

@kmturley
Copy link
Owner

kmturley commented Jul 12, 2023

I'm not familiar with ICE (Stun and TURN), would need to investigate more.

But a quick search found this code:

const configuration = {iceServers: [{urls: 'stun:stun.example.org'}]};
const pc = new RTCPeerConnection(configuration);

https://web.dev/webrtc-infrastructure/#code-webrtc-for-signaling

Compared to my code where I don't pass a configuration:

this.conn = new RTCPeerConnection();

https://github.com/kmturley/webrtc-radio/blob/master/src/app/shared/services/listener.service.ts#L28

I will mark this as a feature request. Although I don't have time to look at it now. Can revisit at a later date, or accept a PR if someone can implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants