Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the refactored new events filters tests from eventing core #3449

Closed
Leo6Leo opened this issue Oct 31, 2023 · 3 comments
Closed

Port the refactored new events filters tests from eventing core #3449

Leo6Leo opened this issue Oct 31, 2023 · 3 comments
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Oct 31, 2023

Problem
Currently, the new filter tests need to be manually ported one at a time whenever a new test is made. With the recent refactor, we can simply import the whole test suite. We should refactor our tests to do this.

Persona:
Which persona is this feature for? Knative Developers

Exit Criteria
The new events filters tests are run with the newly refactored test suite.

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1 day.

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member

Cali0707 commented Nov 2, 2023

PR for eventing core is here: knative/eventing#7424

This isn't ready to work until after that is merged

Copy link
Contributor

github-actions bot commented Feb 1, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2024
@Cali0707
Copy link
Member

Cali0707 commented Feb 1, 2024

This was completed a while ago, closing

@Cali0707 Cali0707 closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants