Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Update Deprecated generate-groups.sh to kube_codegen.sh #636

Open
inspirit941 opened this issue Oct 15, 2024 · 1 comment · May be fixed by #641
Open

Proposal: Update Deprecated generate-groups.sh to kube_codegen.sh #636

inspirit941 opened this issue Oct 15, 2024 · 1 comment · May be fixed by #641
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@inspirit941
Copy link

inspirit941 commented Oct 15, 2024

I've noticed that the generate-groups.sh script currently used in hack/update-codegen.sh is deprecated and no longer functioning. (https://github.com/kubernetes/code-generator/blob/master/generate-groups.sh)

I'd like to propose updating it to kube_codegen.sh to address this issue.

Proposal

  • Replace generate-groups.sh with kube_codegen.sh.

I've personally tested this change by modifying the update-codegen script to use kube_codegen.sh, and it works as expected.

Questions

  • Would it be appropriate to submit a Pull Request with these changes?
  • Are there any additional considerations I should be aware of before proceeding?
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant