Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Repo: knative-sandbox/eventing-istio #1239

Closed
13 of 14 tasks
pierDipi opened this issue Jan 2, 2023 · 8 comments
Closed
13 of 14 tasks

New Repo: knative-sandbox/eventing-istio #1239

pierDipi opened this issue Jan 2, 2023 · 8 comments
Assignees

Comments

@pierDipi
Copy link
Member

pierDipi commented Jan 2, 2023

Repo information

Org: knative-sandbox
Repo: eventing-istio

Purpose (Description):

Eventing integration with istio.

Issue: knative/eventing#6596
WIP Design doc: https://docs.google.com/document/d/1Y9BukjzUxfl920KltVtH4L5gta0pHOt5NEsLqdgZNY4/edit

Sponsoring WG: Eventing

Actions to fulfill

This area is used to track the repo creation process.
The requestor and sponsoring WG lead should perform the steps listed below and cross out the checkmarks when done.
The TOC is involved only in the TOC Gate steps.

  • Add this issue to the TOC project board for review. You are responsible for moving your entry on the board to "Needs Discussion" or "In Progress" as you move forward in this checklist.

You may not be able to use the Projects quick menu on this page. In that case, go to the project board and use the Add cards interface.

  • Send a PR adding entries for this repo in /peribolos/knative-sandbox.yaml. Please mind the alphabetical order when adding to a list.
    • Add the repository and a description.
    • Grant Knative Admin the admin privilege.
    • Grant the sponsoring WG the write privilege.

#1245

TOC Gate: Once the TOC has approved the above, it will merge and Peribolos will create an empty repository.

  • Ask Steering to add the repo to EasyCLA in Slack.

  • (golang) Send a PR to add aliases for knative.dev/$REPONAME import paths (sample).

knative/docs#5380

  • Have a lead from the sponsoring WG bootstrap the Git repository by pushing an
    appropriate "template" repository (basic,
    sample-controller,
    sample-source) to the new repository as
    a git remote. For example:

      git clone https://github.com/knative-sandbox/sample-controller.git
      cd sample-controller
      git remote add newrepo https://github.com/knative-sandbox/$REPONAME.git
      git push newrepo main
  • Add your GitHub ID to the OWNERS file for your repo.

  • Set up prow for a new repo

  • Bootstrap your CI jobs using hack project (look at other sandbox repos for reference)

  • Create a sample PR to verify Prow (e.g., edit the boilerplate README)

  • Verify that within 24 hours the appropriate branch protections have been applied
    requiring tide to pass before PRs are merged.

  • (optional) Send a PR adding the repo to knobots.

@evankanderson
Copy link
Member

👍 from me

@evankanderson
Copy link
Member

We should think about how this affects the install process and the operator before making this a separate set of artifacts from net-istio.

@evankanderson
Copy link
Member

(In particular, we want to make sure that we keep the supported Istio versions in sync between this repo and net-istio)

@dprotaso
Copy link
Member

dprotaso commented Jan 5, 2023

+1

1 similar comment
@psschwei
Copy link
Contributor

+1

@dsimansk
Copy link
Contributor

:+1 good to go

@dprotaso
Copy link
Member

@pierDipi you're all good to go ahead.

@dprotaso dprotaso moved this from Needs discussion to Done in Technical Oversight Backlog Jan 12, 2023
@evankanderson evankanderson moved this from Done to In Progress in Technical Oversight Backlog Jan 12, 2023
pierDipi added a commit to pierDipi/community that referenced this issue Jan 13, 2023
@pierDipi
Copy link
Member Author

/assign

knative-prow bot pushed a commit that referenced this issue Jan 13, 2023
* Add knative-sandbox/eventing-istio

Part of #1239

* Update knative-sandbox.yaml
@pierDipi pierDipi closed this as completed Apr 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Technical Oversight Backlog Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants