Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate more graceful shutdown of the InMemoryChannel #7407

Closed
Cali0707 opened this issue Oct 26, 2023 · 4 comments
Closed

Investigate more graceful shutdown of the InMemoryChannel #7407

Cali0707 opened this issue Oct 26, 2023 · 4 comments
Assignees

Comments

@Cali0707
Copy link
Member

Problem
Currently, we are seeing flaky upgrade tests due to the IMC losing events. This is because the IMC is not persistent, so some events are lost in the upgrade process. We should handle this more gracefully by ensuring that all events have been handled before the channel shuts down, and indicating on new incoming events that they were not handled because the channel is shutting down.

Persona:
Which persona is this feature for?

Exit Criteria
The upgrade tests are no longer flaky from lost events

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 5-7 days

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

/assign

@Cali0707
Copy link
Member Author

cc @pierDipi - did I miss any of the points from the WG discussion on this?

@Cali0707
Copy link
Member Author

@pierDipi do you think we can close this now that #7415 is merged?

@pierDipi
Copy link
Member

pierDipi commented Dec 5, 2023

Yes, thanks for the improvement in #7415

@pierDipi pierDipi closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants