Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative-ingress-gateway changes are overwritten by operator #505

Closed
jheyduk opened this issue Mar 5, 2021 · 2 comments · Fixed by #531
Closed

Knative-ingress-gateway changes are overwritten by operator #505

jheyduk opened this issue Mar 5, 2021 · 2 comments · Fixed by #531
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jheyduk
Copy link

jheyduk commented Mar 5, 2021

Describe the bug
I changed my configuration as described on https://knative.dev/docs/serving/using-a-tls-cert/
On next reconcile my changes are lost.

Expected behavior
The operator should not overwrite the settings.
Otherwise the documentation should extended how to make the changes persist using KnativeServing CRD

To Reproduce
Make some changes on Knative-ingress-gateway and wait for the next reconcile. The added -hosts-Section will disappear

Knative release version
v0.21

@jheyduk jheyduk added the kind/bug Categorizes issue or PR as related to a bug. label Mar 5, 2021
@jheyduk jheyduk changed the title Knative-ingress-gateway gets overwritten by operator Knative-ingress-gateway changes are overwritten by operator Mar 5, 2021
@houshengbo
Copy link
Contributor

houshengbo commented Mar 24, 2021

If you install knative serving with the operator, configure it with the operator.

In terms of Knative-ingress-gateway, you should configure it as the instructions here: https://knative.dev/docs/install/operator/configuring-serving-cr/#replace-the-default-istio-ingressgateway-service or https://knative.dev/docs/install/operator/configuring-serving-cr/#replace-the-knative-ingress-gateway-gateway

If you want to change the default content of knative-ingress-gateway, operator reconciling loop will revert it, because it loads the default knative-ingress-gateway each time and apply in the loop.

@houshengbo
Copy link
Contributor

houshengbo commented Mar 24, 2021

It also reminds me something similar in the old archive:
knative/serving-operator#258
knative/serving-operator#302

Time to revive.
The advanced k8s resource overlays looks charming, but it is still challenging for me to move on in that direction, because it will indicate knative operator has given up the effort to build a strong-typed API.
To support the configuration, I would rather accept the PR to override the servers section for gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants