Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Extend image override logic to Daemonsets #280

Closed
jcrossley3 opened this issue Feb 2, 2020 · 1 comment · Fixed by #281
Closed

Extend image override logic to Daemonsets #280

jcrossley3 opened this issue Feb 2, 2020 · 1 comment · Fixed by #281
Assignees

Comments

@jcrossley3
Copy link
Contributor

jcrossley3 commented Feb 2, 2020

Describe the bug
The forthcoming knative-serving release will deploy the activator as a daemonset, but our image override logic only replaces images in Deployments currently.

Expected behavior
Images for Daemonsets should be subject to the same override logic as for Deployments

To Reproduce
Try overriding the activator images and see that its Daemonset image changes.

Knative release version
Post 0.12

Additional context
This is the change upstream: knative/serving#6624

This issue might lend some justification to #277 as it would be handy to be able to test a released operator with an unreleased manifest.

@savitaashture
Copy link
Contributor

/assign

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants