Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: can we drop certificate-class when http01 is archived #14720

Open
ReToCode opened this issue Dec 8, 2023 · 1 comment
Open

Discussion: can we drop certificate-class when http01 is archived #14720

ReToCode opened this issue Dec 8, 2023 · 1 comment
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@ReToCode
Copy link
Member

ReToCode commented Dec 8, 2023

When net-http01 is removed, there is only one implementation left for KnativeCertificate. We currently have certificate-class with a default value of cert-manager. As there will not be a second implementation, its a bit cumbersome to handle the cert-class in various places without having a second one.

e.g:

func getCertificateClass(cm *corev1.ConfigMap) string {
	// if not specified, we fall back to our default, which is cert-manager
	if class, ok := cm.Data[netcfg.DefaultCertificateClassKey]; ok {
		return class
	}

	return netcfg.CertManagerCertificateClassName
}
...
	class := getCertificateClass(cm)
	switch class {
	case netcfg.CertManagerCertificateClassName:
		return getCertManagerCA(clients)
	default:
		return nil, fmt.Errorf("invalid %s: %s", netcfg.DefaultCertificateClassKey, class)
	}

Let's discuss if we want to drop it.

Copy link

github-actions bot commented Mar 8, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2024
@ReToCode ReToCode added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
Status: No status
Development

No branches or pull requests

1 participant