Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether there are bugs or security risks when using the following extensions(kubernetes.podspec-affinity,kubernetes.podspec-persistent-volume-claim,kubernetes.podspec-persistent-volume-write) of knative? #14918

Closed
zzuchen opened this issue Feb 21, 2024 · 8 comments
Labels
kind/question Further information is requested

Comments

@zzuchen
Copy link

zzuchen commented Feb 21, 2024

Ask your question here:

I am using Krative 1.3 version, and due to the need to set pod anti affinity and PVC, I need to enable kubernetes.podspec-affinity,kubernetes.podspec-persistent-volume-claim,kubernetes.podspec-persistent-volume-write extensions. But in the official documentation, they are set to disabled by default (the official documentation explains that they are in the alpha stage and may have bugs). May I ask what bugs they may have, and has the latest version of knave already resolved these bugs?

@zzuchen zzuchen added the kind/question Further information is requested label Feb 21, 2024
@skonto
Copy link
Contributor

skonto commented Feb 21, 2024

Hi @zzuchen wrt pvcs here is a related comment about maturity: knative/docs#5736 (comment), we would like to move it to GA.
In general when a feature is in Alpha it may have undiscovered bugs and it is at initial stage. It is labeled that way so users have clear expectations. cc @dprotaso if he has anything to add about the affinity stuff but I suppose the same statement holds.

@zzuchen
Copy link
Author

zzuchen commented Feb 22, 2024

Hi @zzuchen wrt pvcs here is a related comment about maturity: knative/docs#5736 (comment), we would like to move it to GA. In general when a feature is in Alpha it may have undiscovered bugs and it is at initial stage. It is labeled that way so users have clear expectations. cc @dprotaso if he has anything to add about the affinity stuff but I suppose the same statement holds.

Thank you for your answer, but I am not using the latest version of knaitve. Are there any improvements in supporting pvc in knaitve version 1.3 and 1.13? Is pvc also mature in knative 1.3 version, can it reach the beta stage or GA stage?

@skonto
Copy link
Contributor

skonto commented Feb 22, 2024

The feature was been used for quite some time so its pretty stable. 1.3 is quite old, I would recommend to upgrade.
The status of the feature should be updated. cc @dprotaso

@zzuchen
Copy link
Author

zzuchen commented Feb 23, 2024

The feature was been used for quite some time so its pretty stable. 1.3 is quite old, I would recommend to upgrade. The status of the feature should be updated. cc @dprotaso

Thank you for your reply. As we are currently unable to update to the latest version of knaitve, we can only use version 1.3 at most. Therefore, may I ask if there have been any reported errors using PVC functionality in this lower version of knaitve?

@skonto
Copy link
Contributor

skonto commented Mar 5, 2024

there have been any reported errors using PVC functionality in this lower version of knaitve?

Not any that I am aware of. You can try it and report back btw.

@zzuchen
Copy link
Author

zzuchen commented Mar 7, 2024

there have been any reported errors using PVC functionality in this lower version of knaitve?

Not any that I am aware of. You can try it and report back btw.

Thank you very much,what‘s more, I have read your submit record about PVC(0682e94), did you only add the validation of the PVC volume in the process of validatevolume of the admission controller?

@skonto
Copy link
Contributor

skonto commented Mar 7, 2024

There was also a PR to add a test #12547 but the core functionality is to add a feature flag and the logic at the Knative validation side. PVC support is what K8s offers nothing more there.
@zzuchen should we close this one or you have more questions?

@zzuchen
Copy link
Author

zzuchen commented Mar 7, 2024

There was also a PR to add a test #12547 but the core functionality is to add a feature flag and the logic at the Knative validation side. PVC support is what K8s offers nothing more there. @zzuchen should we close this one or you have more questions?

Thank you very much,I don't have any more questions.

@zzuchen zzuchen closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants