Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kail needs update in e2e-common.sh #15028

Closed
skonto opened this issue Mar 21, 2024 · 1 comment
Closed

Kail needs update in e2e-common.sh #15028

skonto opened this issue Mar 21, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.

Comments

@skonto
Copy link
Contributor

skonto commented Mar 21, 2024

Expected Behavior

This part in e2e-common.sh is not working as the link for downloading is not valid anymore, it was removed in https://github.com/boz/kail/tree/v0.16.0.

  # Install kail if needed.
  if ! which kail > /dev/null; then
    bash <( curl -sfL https://raw.githubusercontent.com/boz/kail/master/godownloader.sh) -b "$GOPATH/bin"
  fi

Is our kail version up to date? I am trying to see the queue proxy logs in #15027 but was not able yet to do so.

Actual Behavior

Logs are missing. Still checking. Should we evaluate stern btw at some point?

@skonto skonto added kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor. labels Mar 21, 2024
@dprotaso
Copy link
Member

dprotaso commented Apr 1, 2024

I created a PR to fix the kail link - if you wish to change it to stern feel free to do it in a separate PR. I'm not particularly opinionated one way or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.
Projects
None yet
Development

No branches or pull requests

2 participants