Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New charts engine #1072

Closed
yangwao opened this issue Nov 9, 2021 · 8 comments · Fixed by #1110
Closed

New charts engine #1072

yangwao opened this issue Nov 9, 2021 · 8 comments · Fixed by #1110
Assignees
@rhaicode
Labels
$$ ~51-150usd A-chart issues related to charts, somewhere A-research we will research on these koda2 p5 ideas for future

Comments

@yangwao
Copy link
Member

yangwao commented Nov 9, 2021

@roiLeo has raised awareness of the big bundle of current chart

Proposed to use https://www.chartjs.org/
If we manage to keep original functionality, I'm up to it!

Mind making PR against main-nuxt branch
@yangwao yangwao added $$ ~51-150usd A-research we will research on these p5 ideas for future koda2 labels Nov 9, 2021
@vikiival
Copy link
Member

vikiival commented Nov 9, 2021

Since @yangwao is faster than light here is my issue

  • Currently a price chart component has around ~2mb which can be slow for some device

Screenshot 2021-11-09 at 10 11 55

s

@yangwao
Copy link
Member Author

yangwao commented Nov 9, 2021

Referring #279

@yangwao
Copy link
Member Author

yangwao commented Nov 9, 2021

If we would figure out time scaling, I'm up to it https://www.chartjs.org/docs/latest/samples/scales/time-line.html

Seems quite light weight!

@yangwao
Copy link
Member Author

yangwao commented Nov 10, 2021

Stradford was DM me about this, let's try do this

@rhaicode
Copy link
Contributor

Hello! I'm Stradford from the cord. I'll start working on this now

@vikiival
Copy link
Member

Chart.JS
Screenshot 2021-11-10 at 14 36 40

ECharts
Screenshot 2021-11-10 at 14 37 00

continue

@vikiival
Copy link
Member

I'll start working on this now

stage is yours

@yangwao yangwao mentioned this issue Nov 11, 2021
Closed
@rhaicode rhaicode mentioned this issue Nov 12, 2021
Merged
15 tasks
@yangwao yangwao added the A-chart issues related to charts, somewhere label Nov 12, 2021
@rhaicode
Copy link
Contributor

Hello! The progress for this issue is linked in this PR #1110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhaicode rhaicode

Labels
$$ ~51-150usd A-chart issues related to charts, somewhere A-research we will research on these koda2 p5 ideas for future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1072: chartjs integration rhaicode/nft-gallery
3 participants
@yangwao @vikiival @rhaicode