Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Search bar/results leftover fixes #4136

Closed
prachi00 opened this issue Oct 19, 2022 · 7 comments · Fixed by #4138
Closed

Redesign Search bar/results leftover fixes #4136

prachi00 opened this issue Oct 19, 2022 · 7 comments · Fixed by #4138
Labels
enhancement New feature or request

Comments

@prachi00
Copy link
Member

Is your feature request related to a problem?

Originial issue: #4090
current status:
image
the design:
image
on page https://beta.kodadot.xyz/?page=1&redesign=true&search= there are no trading results when focusing on the search bar or pressing "K"

  • Hover effect missing on all cards
  • White mode hover effect: accent light 2
  • dark mode hover effect: #363234
    demo:
search.results.video.mp4

Missing info on collections

image

  • floor and units

Selection

image
how it should look like:
image

  • there is no hover effect on the text. It's not the nav section. When active - bold text

"see all"

  • it should have only the hover effect - bold, not changing any color.
    image

Describe the solution you would like

.

Describe alternatives you have considered

.

Screeenshots

No response

Are there opened related issues?

No response

@prachi00 prachi00 added the enhancement New feature or request label Oct 19, 2022
@prachi00
Copy link
Member Author

@roiLeo how do I get the floor and units from the collectionEntities api?

@exezbcz

  1. for the selection navbar thing, would it be like this everywhere? that is the selection wont be pink and hoverable?
  2. isnt see all a url, so shouldnt it follow the url default css that is it should be accentLight on hover?

prachi00 added a commit that referenced this issue Oct 19, 2022
@prachi00 prachi00 mentioned this issue Oct 19, 2022
18 tasks
@prachi00 prachi00 self-assigned this Oct 19, 2022
@kodabot
Copy link
Collaborator

kodabot commented Oct 19, 2022

ASSIGNED - @prachi00 🔒 LOCKED -> Thursday, October 20th 2022, 13:23:36 UTC -> 36 hours

@prachi00 prachi00 changed the title Search bar/results leftover fixes Redesign Search bar/results leftover fixes Oct 19, 2022
@exezbcz
Copy link
Member

exezbcz commented Oct 19, 2022

hi, thanks for creating the issue
ad 1 what do you mean by all? Its used in search bar results, similar active effect is in navbar, maybe its also going to be used on collection detail tab switch.
ad2 yup, if we go by design, it's wrong. But because its used nearly everywhere, we can leave it for now how it is. Please, just change the default color to black and the hover effect to k-accent

@roiLeo
Copy link
Contributor

roiLeo commented Oct 19, 2022

@roiLeo how do I get the floor and units from the collectionEntities api?

not possible for now with collectionEntities, maybe with seriesById or with kodadot/snek#95

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

Oh, this is related/overlap with

@kodadot kodadot deleted a comment from yangwao Oct 19, 2022
@prachi00
Copy link
Member Author

Oh, this is related/overlap with

yeah I mean everywhere we have tabs like in explore, settings

prachi00 added a commit that referenced this issue Oct 20, 2022
prachi00 added a commit that referenced this issue Oct 20, 2022
@kodabot
Copy link
Collaborator

kodabot commented Oct 20, 2022

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

yangwao added a commit that referenced this issue Oct 25, 2022
@yangwao yangwao mentioned this issue Oct 28, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants