Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide items on user profile #442

Closed
yangwao opened this issue Jun 9, 2021 · 9 comments
Closed

Hide items on user profile #442

yangwao opened this issue Jun 9, 2021 · 9 comments
Labels
$ ~<50usd enhancement New feature or request p4 affecting less than 10% of app

Comments

@yangwao
Copy link
Member

yangwao commented Jun 9, 2021

Whenever someone send you item you don't want to be listed on profile
https://twitter.com/insider0x/status/1402373401851858945

Opensea introduced it as well
https://twitter.com/opensea/status/1402253451585859585

@yangwao yangwao added the enhancement New feature or request label Jun 9, 2021
@ed-iv
Copy link

ed-iv commented Jun 9, 2021

Another use-case is hiding stuff that you've burned. I inadvertently minted a bunch of duplicates due to issues caused by kanaria emote scripts that were subsequently burned in addition to some test mints which I'd like to hide.

@yangwao
Copy link
Member Author

yangwao commented Jun 10, 2021

Another use-case is hiding stuff that you've burned. I inadvertently minted a bunch of duplicates due to issues caused by kanaria emote scripts that were subsequently burned in addition to some test mints which I'd like to hide.

Okay, options came to my thought. Let me know what do you think
Hide by

  • address of sender
  • by selected NFT

@yangwao
Copy link
Member Author

yangwao commented Jun 23, 2021

  • Hide burned NFTs
  • Hide empty collections

@vikiival
Copy link
Member

OK looks like we have a small glitch in subquery

query notBurned {
  nFTEntities(filter: { burned: {equalTo: false }  }) {
    nodes {
      burned
    }
  }
}

It returns empty

@yangwao yangwao added $ ~<50usd p4 affecting less than 10% of app labels Sep 21, 2021
@yangwao
Copy link
Member Author

yangwao commented Sep 21, 2021

We've hide #679 already, but specifically, hide NFT is still a good thing to have.
One way is the user can now burn it, but maybe need to keep it as an access token?

@roiLeo
Copy link
Contributor

roiLeo commented Oct 19, 2021

OK looks like we have a small glitch in subquery

query notBurned {
  nFTEntities(filter: { burned: {equalTo: false }  }) {
    nodes {
      burned
    }
  }
}

It returns empty

workaround

query notBurned {
  nFTEntities(filter: { burned: { distinctFrom: true } }) {
    nodes {
      burned
    }
  }
}

@yangwao
Copy link
Member Author

yangwao commented Oct 20, 2021

I'm up to it, smart!
Maybe @vikiival if approves, let's make PR on profile :)

@vikiival
Copy link
Member

Yup, legit for now!

@vikiival
Copy link
Member

vikiival commented Dec 2, 2021

Closing in favour of #1367

@vikiival vikiival closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd enhancement New feature or request p4 affecting less than 10% of app
Projects
None yet
Development

No branches or pull requests

4 participants