Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore v0.9 feedback #4906

Closed
exezbcz opened this issue Feb 2, 2023 · 5 comments
Closed

Explore v0.9 feedback #4906

exezbcz opened this issue Feb 2, 2023 · 5 comments
Labels
A-explorer p2 core functionality, or is affecting 60% of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Feb 2, 2023

Here we go again.

Sidebar

image

  • we are changing it a bit
    • it does not have borders all around
    • it does not change to bold when its active

make buy now default when you open the explore - user can than close the breadcrumbs

  • own filter disabled when user is not connected; maybe we can add tooltip saying: connect your wallet to use this filter?

Spacing

image

  • space between explore +buttons and the line separating content is too large, make it smaller please
    image
  • gap between side bar and nft cards is too small
  • whole spacing is also connected with
  • Smaller side margins #4857

Connected Issues

@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app A-explorer labels Feb 2, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Feb 3, 2023

artworks-000528979299-op8qu5-t500x500

Checkbox? (need to create NeoCheckbox based on Oruga checkbox)

Filters

Spacing

  • > space between explore +buttons and the line separating content is too large, make it smaller please
  • > gap between side bar and nft cards is too small
    (I've increase it a bit)
  • > whole spacing is also connected with Smaller side margins #4857
    Need to rework spacing helpers

@exezbcz
Copy link
Member Author

exezbcz commented Feb 5, 2023

  • 1px solid border
  • remove radius
  • font-weight bold when active
  • Don't get me wrong about the bold font-weight; we're getting rid of it.

we are changing it a bit
it does not have borders all around
it does not change to bold when its active

the screenshot above shows the side bar in active and nonactive state. We might also remove the hover effect based on the complexity of implementing it.

@yangwao
Copy link
Member

yangwao commented Feb 16, 2023

What's outstanding for feedback?

@exezbcz
Copy link
Member Author

exezbcz commented Feb 18, 2023

What's outstanding for feedback?

sidebar styling

@exezbcz
Copy link
Member Author

exezbcz commented Mar 1, 2023

this looks to be almost finished, I will make maybe follow for these small changes?

spacing is still bit of

The menu bar and the full width divider should have space 40px, applies to collection as well
image

cards and sidebar should have 32px
image

continue in #5143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-explorer p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

No branches or pull requests

3 participants