Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offers tab doesn't show all offers, comparing to Notification #5616

Closed
roiLeo opened this issue Apr 12, 2023 · 4 comments
Closed

Offers tab doesn't show all offers, comparing to Notification #5616

roiLeo opened this issue Apr 12, 2023 · 4 comments
Labels
A-notification bug Something isn't working p3 non-core, affecting less than 40%

Comments

@roiLeo
Copy link
Contributor

roiLeo commented Apr 12, 2023

From #5442 (review)

Tested on /snek/gallery/331660682-7, I can see 4 "offer" events in NotificationBox but only 2 row in Offers tab maybe remove expired?
Capture d’écran 2023-04-07 à 4 42 38 PM

Originally posted by @roiLeo in #5581 (review)

Account address:
bXhWeVLtArWauM8UmbaVdDmXmo5uSDk6DAa2YxQ5zbt2sDcbW

@yangwao yangwao added p3 non-core, affecting less than 40% A-notification labels Apr 12, 2023
@yangwao
Copy link
Member

yangwao commented Apr 12, 2023

I think this is what we've noticed with @exezbcz that in Offers tab we are not showing all offers

@yangwao yangwao changed the title Notifications & Offers tab results Offers tab doesn't show all offers, comparing to Notification Apr 12, 2023
@yangwao yangwao added the bug Something isn't working label Apr 12, 2023
@floyd-li
Copy link
Member

i think i've filtered expired offers in notification. is it still there?

@roiLeo
Copy link
Contributor Author

roiLeo commented Apr 13, 2023

i think i've filtered expired offers in notification. is it still there?

Yep, stil present

query notificationsByAccount {
  offers(where: { nft: { id_eq: "331660682-7" } }) {
    id
    caller
    expiration
    price
    status
  }
  stats: offersConnection(
    orderBy: id_ASC
    where: { nft: { id_eq: "331660682-7" } }
  ) {
    total: totalCount
  }
}

2 results while your query show 4 results

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 15, 2023

won't fix bsx

@roiLeo roiLeo closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-notification bug Something isn't working p3 non-core, affecting less than 40%
Projects
None yet
Development

No branches or pull requests

3 participants