Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change price and solo listing modal #7026

Closed
exezbcz opened this issue Aug 29, 2023 · 4 comments · Fixed by #7230
Closed

Change price and solo listing modal #7026

exezbcz opened this issue Aug 29, 2023 · 4 comments · Fixed by #7230
Assignees
Labels
$ ~<50usd A-item A-modal issues related to modals p3 non-core, affecting less than 40%

Comments

@exezbcz
Copy link
Member

exezbcz commented Aug 29, 2023

image
  • reuses a lot of components from the confirmation modal and
  • Mass listing v1  #6941
  • displaying collection floor
  • Change price only changes the heading in the top part and button copy
  • Floor price and % selectors have the same hover effect and styling as those in mass listing
image

If you have any questions, feel free to ask!

figma file: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=1458%3A19091&mode=design&t=mMjhohc2g1glvuP8-1

@exezbcz exezbcz added $ ~<50usd p3 non-core, affecting less than 40% A-item A-modal issues related to modals labels Aug 29, 2023
@niklasp
Copy link
Contributor

niklasp commented Aug 30, 2023

I dont understand the issue.

reuses a lot of components from the confirmation modal and
displaying collection floor
Floor price and % selectors have the same hover effect and styling as those in mass listing
Is this a feature that should be added or that should be changed

I guess that these are all things you want changed?

@exezbcz
Copy link
Member Author

exezbcz commented Aug 31, 2023

@niklasp

  • Mass listing v1 Mass listing v1  #6941
  • its a follow-up for this
  • it is design of how listing a single item from gallery item should look, there is also change price modal

@hassnian
Copy link
Contributor

hassnian commented Sep 9, 2023

👋

@kodabot
Copy link
Collaborator

kodabot commented Sep 9, 2023

ASSIGNED - @hassnian 🔒 LOCKED -> Sunday, September 10th 2023, 20:49:57 UTC -> 36 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-item A-modal issues related to modals p3 non-core, affecting less than 40%
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants