Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to change price and list at the same time when using masslisting #7168

Closed
prury opened this issue Sep 5, 2023 · 8 comments · Fixed by #7230
Closed

Allow user to change price and list at the same time when using masslisting #7168

prury opened this issue Sep 5, 2023 · 8 comments · Fixed by #7230
Labels
A-mass-listing A-modal issues related to modals bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@prury
Copy link
Member

prury commented Sep 5, 2023

What happened?

Goes after: #7076

When trying two different options(list and change price) at the same time:

masslisting1.mp4
@prury prury added bug Something isn't working p3 non-core, affecting less than 40% labels Sep 5, 2023
@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app A-modal issues related to modals A-mass-listing and removed p3 non-core, affecting less than 40% labels Sep 6, 2023
@hassnian
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Sep 11, 2023

ASSIGNED - @hassnian 🔒 LOCKED -> Tuesday, September 12th 2023, 17:18:04 UTC -> 36 hours

@hassnian
Copy link
Contributor

hassnian commented Sep 11, 2023

@prury could you try to reproduce this with this preview #7226 I think this pr should fix that bug , let me know if it does

also i guess we are not using the change price modal , changing the price works just need to update the ui accordingly

@exezbcz

I see we have different modals for listing and changing the price
CleanShot 2023-09-11 at 10 04 36@2x
CleanShot 2023-09-11 at 10 05 10@2x

but both modals look the same other than the and the title and submit button , for a simple item there is no issue

but how would this look for multiple items
CleanShot 2023-09-11 at 10 19 50@2x

@exezbcz
Copy link
Member

exezbcz commented Sep 11, 2023

But how would this look for multiple items

It would only say list items. There is no other general word that nicely describes you are changing + listing some items. It will stay the same. The main issue was that having these two options in one modal was not enabled .

@prury
Copy link
Member Author

prury commented Sep 11, 2023

@prury could you try to reproduce this with this preview #7226 I think this pr should fix that bug , let me know if it does

will do! ty

@prury
Copy link
Member Author

prury commented Sep 11, 2023

@hassnian both items now show inside the same modal,
image

@hassnian
Copy link
Contributor

awesome!! , since it's kinda related will add "change price modal" since that is missing

@kodabot
Copy link
Collaborator

kodabot commented Sep 12, 2023

ASSIGNMENT EXPIRED - @hassnian has been unassigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mass-listing A-modal issues related to modals bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants