Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @nuxt/image #7807

Closed
yangwao opened this issue Oct 24, 2023 · 8 comments · Fixed by #8185
Closed

add @nuxt/image #7807

yangwao opened this issue Oct 24, 2023 · 8 comments · Fixed by #8185
Assignees
Labels
$ ~<50usd A-lighthouse A-maintenance p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Oct 24, 2023

Try tune and leverage all performance things we could use

Ref

@yangwao yangwao added p2 core functionality, or is affecting 60% of app A-maintenance labels Oct 24, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Oct 24, 2023

duplicate

@pbkompasz
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Nov 1, 2023

ASSIGNED - @pbkompasz 🔒 LOCKED -> Thursday, November 2nd 2023, 09:56:31 UTC -> 24 hours

@pbkompasz pbkompasz mentioned this issue Nov 2, 2023
16 tasks
@pbkompasz
Copy link
Contributor

@yangwao Some of the images link to https://image.w.kodadot.xyz or https://image-beta.w.kodadot.xyz which redirects to the Cloudfare provider. The problem is that the modifiers are lost this way.
To solve this I wrote a custom provider which fetches the images directly from https://imagedelivery.net/... with the modifiers, however when I make the requests I get this error:
ERROR 9429: Flexible variants are not enabled for the account
This is an example of an optimized image: https://imagedelivery.net/jk5b6spi_m_-9qC4VTnjpg/bafybeiatgshrpwwv4cw3kdi5xzvxvbgwtf7hfelbz54vwjwfkdltvcra3e/public/width=200/height=100/fit=cover

@yangwao
Copy link
Member Author

yangwao commented Nov 6, 2023

ERROR 9429: Flexible variants are not enabled for the account

hm I would enable it once CF is back

image

ome of the images link to https://image.w.kodadot.xyz or https://image-beta.w.kodadot.xyz which redirects to the Cloudfare provider.

this is intentionally as we are having pre production environment and production.

To solve this I wrote a custom provider

if it would respect when it's canary, beta or production I'm good

@yangwao
Copy link
Member Author

yangwao commented Nov 7, 2023

Seems it was already on, maybe due CF outage it did not work? cc @pbkompasz

image

There is also this one fixed if you want to try

image

@pbkompasz
Copy link
Contributor

@yangwao It works now, probably it was due to the outage. I tested only a couple of optimization with making requests directly to imagedelivery and the explore page went down from ~35 MB to ~23 MB.
When I tried to make the requests to this worker it redirected to cloudflare-ipfs.com instead of imagedelivery which threw this error:
failed to resolve /ipfs/QmYSgSKuP2oSpE4yBERxm7UGGWLwgpW9ywWwktx53hCAzy/width=240,height=240,fit=cover: no link named "width=240,height=240,fit=cover" under QmYSgSKuP2oSpE4yBERxm7UGGWLwgpW9ywWwktx53hCAzy .
I will look into it tomorrow.

@yangwao
Copy link
Member Author

yangwao commented Nov 10, 2023

explore page went down from ~35 MB to ~23 MB.

fair improvement tho

cool, keep us posted! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-lighthouse A-maintenance p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants