Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodadot mint SDK #89

Open
vikiival opened this issue Jan 11, 2023 · 3 comments
Open

Kodadot mint SDK #89

vikiival opened this issue Jan 11, 2023 · 3 comments

Comments

@vikiival
Copy link
Member

vikiival commented Jan 11, 2023

We need a proper minting SDK:

name:

@kodadot1/mint

Architecture:

It should somehow wrap the minting logic into simple functions.
About design patterns I am thinking to use either Builder, Adapter or Strategy.

Ref:

Patterns:

@roiLeo
Copy link
Contributor

roiLeo commented Jan 11, 2023

hmm.. what problem will it solve? why is it needed in packages repo?
I feel that if we move the logic here it will be harder to update and test new features easily

@vikiival
Copy link
Member Author

hmm.. what problem will it solve?

That when someone is refactoring the code involving transactions I can sleep properly.

why is it needed in packages repo?

Other people can build stuff on the top of the SDK (CLIs, mint shops, whitelabels...)

harder to update

Actually it would be easier to add new chains, so we can have more agnostic logic on frontend

test new features easily

We have vitest so we can write some tests

@yangwao
Copy link
Member

yangwao commented Feb 17, 2023

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants