Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge order should be reversed #6

Open
fverloop opened this issue Mar 2, 2018 · 0 comments
Open

Merge order should be reversed #6

fverloop opened this issue Mar 2, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@fverloop
Copy link
Collaborator

fverloop commented Mar 2, 2018

When using an array on the css prop to merge styles, I expect the order to be in reverse, like CSS.

Expected:

export const H1: FramerComponent<{}> = props => {
  const style = Style({fontSize: 32});

  return <h1 css={[style, props.css]}>{props.children}</h1>;
};

Currently should do this to make it work:

export const H1: FramerComponent<{}> = props => {
  const style = Style({fontSize: 32});

  return <h1 css={[props.css, style]}>{props.children}</h1>;
};
@fverloop fverloop added the bug Something isn't working label Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant