Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lens type-classes instances #3

Open
yairchu opened this issue Jun 15, 2021 · 1 comment
Open

lens type-classes instances #3

yairchu opened this issue Jun 15, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@yairchu
Copy link

yairchu commented Jun 15, 2021

Supporting the appropriate type-classes from lens like Seq does could make transitioning from Seq to Vector as simple as just changing the used type constructor for code using lens.
@yairchu yairchu changed the title lens lens type-class instances Jun 15, 2021
@yairchu yairchu changed the title lens type-class instances lens type-classes instances Jun 15, 2021
@konsumlamm konsumlamm added the enhancement New feature or request label Jun 15, 2021
@konsumlamm
Copy link
Owner

That's a nice idea, but I don't want to add too many dependencies (and lens has a lot). Note that I already have instances for indexed-traversable (which is reexported by lens) and the other instances should be easy to implement.

I wouldn't be opposed to an rrb-vector-lens package which adds orphan instances for the lens type classes, or an optional dependency on lens (but I'm not sure how/if that works).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yairchu @konsumlamm