Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow direct search and download from BioImage Model Zoo #210

Closed
qin-yu opened this issue Mar 7, 2024 · 7 comments · Fixed by #338
Closed

Allow direct search and download from BioImage Model Zoo #210

qin-yu opened this issue Mar 7, 2024 · 7 comments · Fixed by #338
Assignees
Labels
BioImage.IO Related to BioImage.IO and AI4Life enhancement New feature or request

Comments

@qin-yu
Copy link
Collaborator

qin-yu commented Mar 7, 2024

Hey @oeway are you coming to EMBL on 11 March? I'll pass by and consult you the best way of allowing users to use models from Zoo in PlantSeg.

@qin-yu qin-yu added the enhancement New feature or request label Mar 7, 2024
@oeway
Copy link

oeway commented Mar 7, 2024

Unfortunately I won't be able to join, however Weize @Nanguage will join, so please discuss with him.

Not sure what you mean exactly, but maybe you can create a bioengine app for plantseg, basically a tailored version of https://github.com/bioimage-io/bioengine-web-client

@Nanguage
Copy link

Nanguage commented Mar 7, 2024

Hi qin-yu, I will participate in the Hackathon. We can communicate face-to-face then!

@qin-yu
Copy link
Collaborator Author

qin-yu commented Mar 7, 2024

You are right, @oeway, as of now, there's only a vague idea rather than a concrete plan. I was trying to explore what options are currently available for users to access or search for models in the zoo via Napari and CLI.

I'm looking forward to meeting you next week, @Nanguage.

@qin-yu
Copy link
Collaborator Author

qin-yu commented Mar 13, 2024

Current PlantSeg model zoo

PlantSeg has a YAML file with hard-coded records of models including the link to weight files on Zenodo.

Adding BioImage.IO model zoo: Method 1

Since all models from PlantSeg are uploaded to BioImage.IO and Zenodo, we can simply update the list of models in the PlantSeg model zoo at start-up.

  1. Discover all compatible models
  2. Avoid duplicate in the local record (by removing current hard-coded record completely?)
  3. Separate the dropdown list by a horizontal line and ideally a section name

Adding BioImage.IO model zoo: Method 2

To minimise the changes, add a widget to let users add a model from BioImage.IO model zoo just like adding a custom model.

  1. Discover all compatible models
  2. Show models in that widget for users to add

@qin-yu
Copy link
Collaborator Author

qin-yu commented Mar 13, 2024

Adding BioImage.IO model zoo: Method 3

Why bother running inference on our own code and filter BioImage.IO model zoo? Just use bioimageio.core and use all models available on the zoo : )

@qin-yu
Copy link
Collaborator Author

qin-yu commented Mar 13, 2024

My Plan

Maybe I don't have to directly change the core of PlantSeg inference to bioimageio.core.

  1. Add compatible BioImage.IO model zoo records in PlantSeg on startup
  2. Replace PlantSeg hard-coded records by 1
  3. Add bioimageio.core as alternative inference engine
  4. Replace PlantSeg inference by 3

@qin-yu
Copy link
Collaborator Author

qin-yu commented Mar 13, 2024

Potential Issues

  1. If PlantSeg wants to go generic in bioimage community, using bioimageio.core would greatly benefit PlantSeg; otherwise, PlantSeg loses the generalist capability of growing into segment-everything tool

@qin-yu qin-yu self-assigned this Mar 20, 2024
@qin-yu qin-yu added the BioImage.IO Related to BioImage.IO and AI4Life label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BioImage.IO Related to BioImage.IO and AI4Life enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants