Network Type may not be being verified in project

[amazuerar]

Dear Developer!

My name is Alejandro Mazuera-Rozo, I am a PhD Student at Universidad de los Andes, and at Università della Svizzera italiana. I am part of a research on the usage of network libraries within android apps. As a result of this we identified some code locations that might have network related problems.

In this case, we present the code locations that are related to a missing validation of network type within the project since some network operations are being performed in the project. As you might know, a device can have various types of network connections. For the full list of possible network types, see https://developer.android.com/reference/android/net/ConnectivityManager. Therefore it is recommended for the app to identify the type of network available before performing a network operation.

In order to address this issue we recommend you to visit:

1. https://developer.android.com/training/basics/network-ops/managing
2. https://developer.android.com/training/efficient-downloads/connectivity_patterns

Potential Code Location without Network type validation

Despite the fact the verification of WIFI exists by using getTypeName(), this approach was deprecated in API level 28. Applications should instead use NetworkCapabilities#hasTransport or requestNetwork(android.net.NetworkRequest, android.net.ConnectivityManager.NetworkCallback) to request an appropriate network.

hacs/app/src/main/java/io/mainframe/hacs/main/NetworkStatus.java

Lines 108 to 113 in c92d4c7

	final NetworkInfo ni = cm.getNetworkInfo(network);
	if (ni.getTypeName().equalsIgnoreCase("WIFI")) {
	if (ni.isConnected()) {
	hasWifi = true;
	}