Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add nodeSelector for mimir-proxy-deployment #3519

Open
2 tasks done
nantiferov opened this issue Jun 26, 2024 · 0 comments
Open
2 tasks done

[Feature] Add nodeSelector for mimir-proxy-deployment #3519

nantiferov opened this issue Jun 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nantiferov
Copy link

nantiferov commented Jun 26, 2024

Problem Statement

mimir-proxy was added in #2201 and from my understanding, now it's impossible to set nodeSelector via Helm values, since it's missing in template https://github.com/kubecost/cost-analyzer-helm-chart/blob/develop/cost-analyzer/templates/mimir-proxy-deployment-template.yaml

Solution Description

Add ability to define optional nodeSelector, which will be used in mimir-proxy-deployment-template.yaml template.
Not sure, but probably it could be set in spec.values.global.mimirProxy or create a new section for it.

Btw, it's also impossible to define resources requests/limits for mimir-proxy, which would be useful to add as well I think. Since now they're not set.

Alternatives

No response

Additional Context

I can prepare PR for this feature if solution sounds good.

Troubleshooting

  • I have read and followed the issue guidelines and this is a feature request only for the Helm chart.
  • I have searched other issues in this repository and mine is not recorded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants