Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is readinessProbe respected for blocking reboot? #973

Open
x3nb63 opened this issue Sep 5, 2024 · 3 comments
Open

is readinessProbe respected for blocking reboot? #973

x3nb63 opened this issue Sep 5, 2024 · 3 comments

Comments

@x3nb63
Copy link

x3nb63 commented Sep 5, 2024

I have Pods that make the readinessProbe return false to tell K8s "I am busy", which has the effect that Service objects will not direct requests to them.

Given what these Pods do, it be very bad to reboot the node while the probe says "busy".

Is this considered by kured?

@evrardjp
Copy link
Collaborator

kured/cmd/kured/main.go

Lines 398 to 403 in 969926d

fieldSelector := fmt.Sprintf("spec.nodeName=%s,status.phase!=Succeeded,status.phase!=Failed,status.phase!=Unknown", kb.nodename)
for _, labelSelector := range kb.filter {
podList, err := kb.client.CoreV1().Pods("").List(context.TODO(), metav1.ListOptions{
LabelSelector: labelSelector,
FieldSelector: fieldSelector,
Limit: 10})
is what we use nowadays for filtering.

Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@x3nb63
Copy link
Author

x3nb63 commented Dec 18, 2024

i like to really test this but have negative priority on it ... will take time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants