Hi @ritwikranjan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Hey @aojea, Can you take a look and let me know if it can be improved in any way?

@wojtek-t do you know if this code is being used somewhere?
I honestly can't remember and I will not have time until December to check on this, sorry

Hi @aojea, Would you be able to take a look at these changes now?

We need

1. identify where are these tests running
2. split the PR in independent commits, so it can be easy to review, the modification of the makefile should be independent of the commit that refactors the test code, ...
3. explain how we probe these works (maybe we just need to know .1) and we merge and iterate, that is fine with me too

Okay, sounds good to me, I'll go ahead and split into commits.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ritwikranjan
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi @aojea, is there anything else I can do to better this?

We need

1. identify where are these tests running
2. split the PR in independent commits, so it can be easy to review, the modification of the makefile should be independent of the commit that refactors the test code, ...
3. explain how we probe these works (maybe we just need to know .1) and we merge and iterate, that is fine with me too

missing step .1 and 3. , how can we sure this does not break anything?

@aojea For 1 & 3, I have not found any explicit place where these tests are used directly however I have made sure keep backward compatibility, all the targets in Makefile still give the same output and the older images of nptest also work in the same way. Whatever changes are made are either using extra flag (such as -json) or by keeping the api definitions intact. Now the proof that the changes work, we are currently using a fork Azure/perf-tests for testing an open source project Retina. Let me know if you want details of the implementations for the same. If you are aware of any other usage of this tool do let me know and i'll do test out those as well.

/ok-to-test

do you think you can add a manual job in https://github.com/kubernetes/test-infra so we can at least now if it works?

/retest

@aojea I have addressed the failing linter tests.

I will add a couple of scripts in kubernetes/test-infra in experiment directory in order to verify both the cli as well the api. Thanks for taking the time to look into this.

/retest