Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run/build scripts: replace hard coded docker CR with what is available in user's local env #1352

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Saumya40-codes
Copy link

@Saumya40-codes Saumya40-codes commented Jan 20, 2025

What this PR does / why we need it:

  • Currently at few place in bash scripts we were using docker as the only option which might not be suitable to user using another (like podman)

  • This PR, replaces such hardcoded docker instance and replacing them with the container runtime of the user's local env

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1306

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


cc: @dhiller @brianmcarey

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 20, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stu-gott for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Contributor

Hi @Saumya40-codes. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Saumya40-codes
Copy link
Author

At many places, such solution already exists in the repo. So I've carry forwarded the same approach to check for docker or podman

@Saumya40-codes Saumya40-codes changed the title run/build: replace hard coded docker CR with what is available in user's local env run/build scripts: replace hard coded docker CR with what is available in user's local env Jan 21, 2025
Signed-off-by: Saumyacodes-40 <[email protected]>
@dhiller
Copy link
Contributor

dhiller commented Jan 23, 2025

/test check-provision-k8s-1.30

@Saumya40-codes
Copy link
Author

Saumya40-codes commented Jan 23, 2025

Test passes!

If its all right, then this file also needs to be changed accordingly so I can update it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container,build: replace hard coded docker with what is available, similarly to what we do elsewhere
3 participants