Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support provision with Podman or fix docs #1358

Open
victortoso opened this issue Jan 24, 2025 · 1 comment
Open

Support provision with Podman or fix docs #1358

victortoso opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
kind/bug sig/buildsystem Denotes an issue or PR that relates to changes in the build system.

Comments

@victortoso
Copy link
Member

What happened:
Not sure what the preference, so I've created an issue. The docs.
Trying to do provision of k8s-1.32 with podman fails with:

+ [[ linux,k8s =~ linux.* ]]
+ cd ../centos9
+ ./build.sh
./build.sh: line 7: docker: command not found

Which is a 7 line file with the content

#!/bin/bash -e

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

centos_version="$(cat $DIR/version | tr -d '\n')"

docker build --build-arg BUILDARCH=$(uname -m) --build-arg centos_version=$centos_version . -t quay.io/kubevirtci/centos9

So I've just changed it to podman to see how it goes well till...

[3/3] STEP 9/11: COPY --from=imageartifactdownload /vmlinuz-* /vmlinuz
--> 83b60df0cc8d
[3/3] STEP 10/11: COPY --from=imageartifactdownload /initramfs-* /initrd.img
--> 70327c59452c
[3/3] STEP 11/11: COPY scripts/* /
[3/3] COMMIT quay.io/kubevirtci/centos9
--> d2bba27c6288
Successfully tagged quay.io/kubevirtci/centos9:latest
d2bba27c6288708ba906119415a923636bd3a0b5865f039a7e75d53ad85d2c47
+ SLIM_MODE=
+ false
+ ../gocli/build/cli provision 1.32 --phases linux,k8s
panic: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

goroutine 1 [running]:
kubevirt.io/kubevirtci/cluster-provision/gocli/cmd.provisionCluster(0xc00026c908, {0xc0003d88a0?, 0x4?, 0x1acc6b1?})
        /home/toso/src/kubevirt/kubevirtci/cluster-provision/gocli/cmd/provision.go:153 +0x2bab
github.com/spf13/cobra.(*Command).execute(0xc00026c908, {0xc0003d8840, 0x3, 0x3})
        /home/toso/src/kubevirt/kubevirtci/cluster-provision/gocli/vendor/github.com/spf13/cobra/command.go:983 +0xaaa
github.com/spf13/cobra.(*Command).ExecuteC(0xc00026c308)
        /home/toso/src/kubevirt/kubevirtci/cluster-provision/gocli/vendor/github.com/spf13/cobra/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
        /home/toso/src/kubevirt/kubevirtci/cluster-provision/gocli/vendor/github.com/spf13/cobra/command.go:1039
kubevirt.io/kubevirtci/cluster-provision/gocli/cmd.Execute()
        /home/toso/src/kubevirt/kubevirtci/cluster-provision/gocli/cmd/root.go:47 +0x18
main.main()
        /home/toso/src/kubevirt/kubevirtci/cluster-provision/gocli/cmd/cli/main.go:8 +0xf

Looking at gocli, seems that docker is hardcoded there.

What you expected to happen:
Provision with podman succeed.

How to reproduce it (as minimally and precisely as possible):
Just try it without docker installed

Additional context:
Not urgent, just a nice to have.

Environment:

  • KubeVirt version (use virtctl version): N/A
  • Kubernetes version (use kubectl version): N/A
  • VM or VMI specifications: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Install tools: N/A
  • Others: N/A
@dosubot dosubot bot added the sig/buildsystem Denotes an issue or PR that relates to changes in the build system. label Jan 24, 2025
@aerosouund
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug sig/buildsystem Denotes an issue or PR that relates to changes in the build system.
Projects
None yet
Development

No branches or pull requests

2 participants