refector: refector node webhook #578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googs1025
force-pushed
the
refector_node_webhook
branch
from
edcc4f3 to
52da9dc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 55.94% 56.01% +0.07%
==========================================
Files 532 576 +44
Lines 49593 66980 +17387
==========================================
+ Hits 27744 37520 +9776
- Misses 18316 25468 +7152
- Partials 3533 3992 +459
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WangZzzhe
reviewed
May 8, 2024
WangZzzhe
reviewed
May 8, 2024
googs1025
force-pushed
the
refector_node_webhook
branch
from
52da9dc to
abf090f
Compare
|
@caohe @luomingmeng @WangZzzhe /PTAL thanks! |
WangZzzhe
reviewed
May 22, 2024
| if err != nil { | ||
| klog.Error(err) | ||
| } else { | ||
| newCapacity = &quantity | ||
| klog.V(6).Infof("node %s mem capacity by annotation: %v", node.Name, newCapacity.String()) | ||
| klog.V(6).Infof("node %s %s capacity by annotation: %v", node.Name, newCapacity.String(), newCapacity.String()) |
There was a problem hiding this comment.
why is newCapacity.String() logged twice?
WangZzzhe
reviewed
May 22, 2024
| if err != nil { | ||
| klog.Error(err) | ||
| } else { | ||
| newAllocatable = &quantity | ||
| klog.V(6).Infof("node %s mem allocatable by annotation: %v", node.Name, newAllocatable.String()) | ||
| klog.V(6).Infof("node %s %s allocatable by annotation: %v", node.Name, newCapacity.String(), newAllocatable.String()) |
There was a problem hiding this comment.
The second param was used to log resource type, and the same is true for line 93
Signed-off-by: googs1025 <[email protected]>
googs1025
force-pushed
the
refector_node_webhook
branch
from
abf090f to
3c34e87
Compare
|
sorry for late. can we go next? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind refactor
What this PR does / why we need it:
refactor node webhook
Which issue(s) this PR fixes:
Fix: #577
Special notes for your reviewer: