Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodProtector-level rejection count metrics #33

Open
SOF3 opened this issue Nov 28, 2024 · 0 comments
Open

PodProtector-level rejection count metrics #33

SOF3 opened this issue Nov 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@SOF3
Copy link
Member

SOF3 commented Nov 28, 2024

  • Add a .status.rejectionHistory field in the PodProtector CRD that stores the last N rejections (or rejection buckets). N may be configured through
  • Expand the retrybatch adaptor to support two types of requests: admission attempt (the current type) and rejection log. Submit a rejection log request when an admission attempt is rejected. The rejection log request has no timeout, but it gets canceled when the rejection log cannot fit into the latest PodProtector status (e.g. more than N rejections (or rejection buckets) were created afterwards, or PodProtector is deleted, or other errors).
  • Aggregate the rejection history status in the past few minutes in generator/monitor. generator/observer/metrics can report this as a gauge metric (or a histogram metric where each rejection bucket is a histogram bucket) indicating the number of PodProtectors with rejections during the (last) rejection bucket.
@SOF3 SOF3 added the enhancement New feature or request label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant