You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 26, 2019. It is now read-only.
Hi Jason,
Happy holidays! I created a pull request for what I have so far, for your consideration.
Most of the damage is in these two files: ComputerPresenter and ComputerView. I created a new package and class called Printers. I also made a minor change in SiteMenu (changed “Computers” to “Printers”).
My goal was not to break anything with the application, just to add something new, so everything that worked on the Computers screen previously should still work as-is, though it looks a bit different.
The UI is basically done, though some of the columns could have less confusing names I think. The IP addresses do not populate under Installed Printers yet, but I will find a way to pull that data.
I haven’t yet actually tested the code; well, I tested it lightly but I haven’t yet figured out how to add my Brother printer to linux using lpadmin. Right now what I added is hard-coded to look for the script in /usr/local/bin. I would be curious to know if it does work :D I would also prefer to do away with the script as a file as it adds unnecessary points of failure, adding printer models requires code/script changes, and it isn’t cross-platform friendly.
I will wait to see your feedback before I present a plan to finish the feature.
Regards,
Kent McKinney
From: Jason Short [mailto:[email protected]]
Sent: Thursday, November 3, 2016 7:34 PM
To: kumoregdev/kumoreg <[email protected]>
Cc: kentpmckinney <[email protected]>; Assign <[email protected]>
Subject: [kumoregdev/kumoreg] Manage printers from inside app (#60)
Add a Manage Printers page to allow adding, removing, and changing details of printers.
Considerations:
* A printer may have more than one computer printing to it. That's been handy when one breaks
* Adding a duplicate printer shouldn't break anything
* Changing the type of a printer shouldn't break anything
Can run addprinter.sh to add a printer, or run lpadmin directly.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub <#60> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AQgTpmZapygp570CmVLd06NIG1e0ma6Mks5q6pmVgaJpZM4KpIid> . <https://github.com/notifications/beacon/AQgTptSfoShHapvK46bNMNQYTmt_ouzWks5q6pmVgaJpZM4KpIid.gif>
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add a Manage Printers page to allow adding, removing, and changing details of printers.
Considerations:
Can run addprinter.sh to add a printer, or run lpadmin directly.
The text was updated successfully, but these errors were encountered: