Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary check in sparse LCP computation. #4

Open
kurpicz opened this issue Jan 11, 2015 · 0 comments
Open

Unnecessary check in sparse LCP computation. #4

kurpicz opened this issue Jan 11, 2015 · 0 comments
Labels
enhancement
Milestone
Code cleanup and ...

Comments

@kurpicz
Copy link
Owner

kurpicz commented Jan 11, 2015

There is an unnecessary computation of either t of in sais.c:701 and sais.c:731

The latter looks like and q never exceeds t.

t = PLCP[j];          // accesses DELTA-value
q = RA[j+1]-RA[j];    // length difference
PLCP[j++] = p;
p -= (t > q) ? t : q; // decrease p by larger of t and q
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Code cleanup and documentation
Development

No branches or pull requests
1 participant
@kurpicz