From c1fede59c3494c2c99b7d8d9ff7242cf89d36db7 Mon Sep 17 00:00:00 2001 From: ayrus02 <34953163+ayrus02@users.noreply.github.com> Date: Wed, 8 Jan 2025 01:42:09 +0700 Subject: [PATCH] Bug Fix: Add Indonesian and Malaysian Currency Transformer (Reopen) (#184) * Update ManagesCurrencyTransformers.php Add Indonesian Currency Transformer * Update ManagesCurrencyTransformers.php Add Malaysian Currency Transformer * Update EnglishDictionary.php Add Indonesian Rupiah and Malaysian Ringgit to EnglishDictionary.php * Add Indonesian Rupiah and Malaysian Ringgit Unit Test * Fix the mistaken unit test * Fix first letter capital in Rupiah IDR and Ringgit MYR --- src/Concerns/ManagesCurrencyTransformers.php | 2 ++ src/Language/English/EnglishDictionary.php | 2 ++ .../EnglishCurrencyTransformerTest.php | 10 ++++++++++ 3 files changed, 14 insertions(+) diff --git a/src/Concerns/ManagesCurrencyTransformers.php b/src/Concerns/ManagesCurrencyTransformers.php index 5a0f0c88..ea613946 100644 --- a/src/Concerns/ManagesCurrencyTransformers.php +++ b/src/Concerns/ManagesCurrencyTransformers.php @@ -22,9 +22,11 @@ trait ManagesCurrencyTransformers 'es' => Transformer\SpanishCurrencyTransformer::class, 'fr' => Transformer\FrenchCurrencyTransformer::class, 'hu' => Transformer\HungarianCurrencyTransformer::class, + 'id' => Transformer\IndonesianCurrencyTransformer::class, 'ka' => Transformer\GeorgianCurrencyTransformer::class, 'lt' => Transformer\LithuanianCurrencyTransformer::class, 'lv' => Transformer\LatvianCurrencyTransformer::class, + 'ms' => Transformer\MalaysianCurrencyTransformer::class, 'pl' => Transformer\PolishCurrencyTransformer::class, 'pt_BR' => Transformer\PortugueseBrazilianCurrencyTransformer::class, 'ro' => Transformer\RomanianCurrencyTransformer::class, diff --git a/src/Language/English/EnglishDictionary.php b/src/Language/English/EnglishDictionary.php index 63cf866c..ba979fb5 100644 --- a/src/Language/English/EnglishDictionary.php +++ b/src/Language/English/EnglishDictionary.php @@ -61,6 +61,7 @@ class EnglishDictionary implements Dictionary 'HKD' => [['Hong Kong dollar'], ['cent']], 'HRK' => [['Croatian kuna'], ['lipa']], 'HUF' => [['forint'], ['filler']], + 'IDR' => [['rupiah'], ['sen']], 'ILS' => [['new sheqel', 'new sheqels'], ['agora', 'agorot']], 'ISK' => [['Icelandic króna'], ['aurar']], 'JPY' => [['yen'], ['sen']], @@ -71,6 +72,7 @@ class EnglishDictionary implements Dictionary 'MKD' => [['Macedonian dinar'], ['deni']], 'MRO' => [['ouguiya'], ['khoums']], 'MTL' => [['Maltese lira'], ['centym']], + 'MYR' => [['ringgit'], ['sen']], 'NGN' => [['Naira'], ['kobo']], 'NOK' => [['Norwegian krone'], ['oere']], 'PHP' => [['peso'], ['centavo']], diff --git a/tests/CurrencyTransformer/EnglishCurrencyTransformerTest.php b/tests/CurrencyTransformer/EnglishCurrencyTransformerTest.php index 0c671cab..8c357453 100644 --- a/tests/CurrencyTransformer/EnglishCurrencyTransformerTest.php +++ b/tests/CurrencyTransformer/EnglishCurrencyTransformerTest.php @@ -34,6 +34,16 @@ public function providerItConvertsMoneyAmountToWords(): array [-72925, 'USD', 'minus seven hundred twenty-nine dollars twenty-five cents'], [-89425, 'USD', 'minus eight hundred ninety-four dollars twenty-five cents'], [-99925, 'USD', 'minus nine hundred ninety-nine dollars twenty-five cents'], + [70800000, 'IDR', 'seven hundred eight thousand rupiahs'], + [276037213, 'IDR', 'two million seven hundred sixty thousand three hundred seventy-two rupiahs thirteen sens'], + [857998800, 'IDR', 'eight million five hundred seventy-nine thousand nine hundred eighty-eight rupiahs'], + [2227500000, 'IDR', 'twenty-two million two hundred seventy-five thousand rupiahs'], + [-191418500, 'IDR', 'minus one million nine hundred fourteen thousand one hundred eighty-five rupiahs'], + [7200000, 'MYR', 'seventy-two thousand ringgits'], + [177537065, 'MYR', 'one million seven hundred seventy-five thousand three hundred seventy ringgits sixty-five sens'], + [247314700, 'MYR', 'two million four hundred seventy-three thousand one hundred forty-seven ringgits'], + [980000000, 'MYR', 'nine million eight hundred thousand ringgits'], + [-135522300, 'MYR', 'minus one million three hundred fifty-five thousand two hundred twenty-three ringgits'], ]; } }