From 324a6487c1fbb265fc917661f8362a2ca0c1cb83 Mon Sep 17 00:00:00 2001 From: chenkovsky Date: Thu, 26 Dec 2024 02:06:56 +0000 Subject: [PATCH] fix: is not false crash --- python/python/tests/test_filter.py | 4 ++++ rust/lance-datafusion/src/planner.rs | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/python/python/tests/test_filter.py b/python/python/tests/test_filter.py index 2fad73a7b8..cc864ea245 100644 --- a/python/python/tests/test_filter.py +++ b/python/python/tests/test_filter.py @@ -86,6 +86,10 @@ def test_sql_predicates(dataset): ("str = 'aa'", 16), ("str in ('aa', 'bb')", 26), ("rec.bool", 50), + ("rec.bool is true", 50), + ("rec.bool is not true", 50), + ("rec.bool is false", 50), + ("rec.bool is not false", 50), ("rec.date = cast('2021-01-01' as date)", 1), ("rec.dt = cast('2021-01-01 00:00:00' as timestamp(6))", 1), ("rec.dt = cast('2021-01-01 00:00:00' as timestamp)", 1), diff --git a/rust/lance-datafusion/src/planner.rs b/rust/lance-datafusion/src/planner.rs index e9237f1aa2..aa596d05c7 100644 --- a/rust/lance-datafusion/src/planner.rs +++ b/rust/lance-datafusion/src/planner.rs @@ -636,7 +636,7 @@ impl Planner { })) } SQLExpr::IsFalse(expr) => Ok(Expr::IsFalse(Box::new(self.parse_sql_expr(expr)?))), - SQLExpr::IsNotFalse(_) => Ok(Expr::IsNotFalse(Box::new(self.parse_sql_expr(expr)?))), + SQLExpr::IsNotFalse(expr) => Ok(Expr::IsNotFalse(Box::new(self.parse_sql_expr(expr)?))), SQLExpr::IsTrue(expr) => Ok(Expr::IsTrue(Box::new(self.parse_sql_expr(expr)?))), SQLExpr::IsNotTrue(expr) => Ok(Expr::IsNotTrue(Box::new(self.parse_sql_expr(expr)?))), SQLExpr::IsNull(expr) => Ok(Expr::IsNull(Box::new(self.parse_sql_expr(expr)?))),