Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Healthcheck Testing/Blank database name #37

Open
reynoldsalec opened this issue Mar 11, 2024 · 0 comments
Open

Better Healthcheck Testing/Blank database name #37

reynoldsalec opened this issue Mar 11, 2024 · 0 comments

Comments

@reynoldsalec
Copy link
Member

We just implemented a fix to handle situations where the user specifies blank dbname/username for the db config. Ex:

services:
  database:
    type: postgres
      creds:
        user: customusername
        database: customdbname

The fix: 893831a

I put in a "test case" in the custom example to make sure a blank user wouldn't fail the healthcheck or otherwise create problems, however, I'm not testing blank database values. From some quick manual testing it looked like those worked ok, but would be good to explicitly test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant