Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore history didn't restore features #12566

Open
5 tasks done
warren830 opened this issue Jan 9, 2025 · 1 comment · May be fixed by #12563
Open
5 tasks done

Restore history didn't restore features #12566

warren830 opened this issue Jan 9, 2025 · 1 comment · May be fixed by #12563
Labels
🐞 bug Something isn't working 🌊 feat:workflow Workflow related stuff.

Comments

@warren830
Copy link
Contributor

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

0.15.0

Cloud or Self Hosted

Cloud, Self Hosted (Docker), Self Hosted (Source)

Steps to reproduce

when restored the workflow, no feature will be restored
image

✔️ Expected Behavior

we should also keep feature

❌ Actual Behavior

features are wiped

@warren830 warren830 linked a pull request Jan 9, 2025 that will close this issue
5 tasks
@dosubot dosubot bot added 🌊 feat:workflow Workflow related stuff. 🐞 bug Something isn't working labels Jan 9, 2025
Copy link

dosubot bot commented Jan 9, 2025

The issue you're experiencing, where the "restore history" functionality does not restore features, might be related to how the restoration process is implemented. The handleRestore and handleLoadBackupDraft functions are responsible for restoring the workflow, including features. These functions should update the workflow canvas and restore features from the backupDraft stored in the workflowStore [1][2].

However, there are known limitations with the "restore history" feature, such as certain actions not triggering state changes, which might affect the restoration of features [3]. It could be beneficial to check if these limitations are impacting your specific use case.

If the issue persists, reviewing the implementation of these functions and ensuring that the featuresStore is correctly updated during the restoration process might help identify the problem.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🌊 feat:workflow Workflow related stuff.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant