[kitsune] Fix external project build #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2024 13:05
…e and excess newlines from elsewhere.
Because of the way the build system was set up, the targets and kitrt would be "installed" at build time i.e. when running ninja/make as opposed to ninja install/make install. This fixes that behavior and only installs during ninja build/ninja install. When building, there will be messages that suggest that those targets are actually being installed, but they are being "installed" to a subdirectory within the build directory.
|
I have not actually tested the runtime behavior. I don't expect that to be affected. |
|
Somehow, some unrelated commits got mixed in with this. Will open a new PR. Ignore this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way the build system was set up, the targets and kitrt would be
"installed" at build time i.e. when running ninja/make as opposed to
ninja install/make install. This fixes that behavior and only installs during
ninja build/ninja install. When building, there will be messages that suggest
that those targets are actually being installed, but they are being "installed"
to a subdirectory within the build directory.