Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOS Builder refactor #28

Closed
Yurlungur opened this issue Sep 22, 2021 · 1 comment
Closed

EOS Builder refactor #28

Yurlungur opened this issue Sep 22, 2021 · 1 comment
Assignees
@Yurlungur @dholladay00 @mauneyc-LANL
Labels
enhancement New feature or request

Comments

@Yurlungur
Copy link
Collaborator

To enable easy construction of nested variants, I wrote the EosBuilder. I believe this machinery is becoming overly complex and cumbersome. It needs a refactor.

This is potentially related to #5, as if downstream codes define which variants they consider "valid," then the builder will need to be modified substantially to support this flexibility.
@Yurlungur Yurlungur added the enhancement New feature or request label Sep 22, 2021
@Yurlungur Yurlungur mentioned this issue Apr 11, 2023
Closed
@Yurlungur Yurlungur mentioned this issue Oct 13, 2023
Merged
6 tasks
@Yurlungur
Copy link
Collaborator Author

Resolved by #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yurlungur Yurlungur

@dholladay00 dholladay00

@mauneyc-LANL mauneyc-LANL

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Yurlungur @dholladay00 @mauneyc-LANL