Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

Create a CONTRIBUTING.md file #168

Closed
igorsantos07 opened this issue Feb 10, 2014 · 3 comments
Closed

Create a CONTRIBUTING.md file #168

igorsantos07 opened this issue Feb 10, 2014 · 3 comments

Comments

@igorsantos07
Copy link
Member

We should state what are the code style guidelines and whatever other rules for contributions we have (I think that, for now, only code style haha).

I think that the CS guideline we're following is: PSR-1 with braces in the same line. However, my memory is awful, so this should be investigated in the Ardent main class before commiting a CS guideline into the repository.

Inspired by #151

@dalabarge
Copy link
Contributor

I'm all for PSR-1 at a minimum. However, I'd recommend that such a package follows PSR-2. If we can raise the standard for contributions then we ensure a higher quality code that is more accessible to more developers. Any chance we can take to put it a step further towards beautifully written code, the better. Entrust and other libraries will follow to some lesser extent effectively bringing up the quality of 3rd party Laravel packages with it.

@igorsantos07
Copy link
Member Author

👍

@igorsantos07
Copy link
Member Author

Guess this is superseeded by #268

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants