Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE-MIDI/src/hardware/BLEMIDI_ESP32_NimBLE.h compile error #96

Open
RCPilot1604 opened this issue Jan 2, 2025 · 5 comments
Open

BLE-MIDI/src/hardware/BLEMIDI_ESP32_NimBLE.h compile error #96

RCPilot1604 opened this issue Jan 2, 2025 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@RCPilot1604
Copy link

Attempted to compile a previously working piece of code which now produces the following compilation error.
The error is in line 144 and 145 of Arduino-BLE-MIDI/src/hardware/BLEMIDI_ESP32_NimBLE.h.

I suspect that there was a migration of the h2zero/NimBLE-Arduino library, causing the code to break.

In file included from src/main.cpp:4:
.pio/libdeps/esp32doit-devkit-v1/BLE-MIDI/src/hardware/BLEMIDI_ESP32_NimBLE.h: In member function 'bool bleMidi::BLEMIDI_ESP32_NimBLE::begin(const char*, bleMidi::BLEMIDI_Transport<bleMidi::BLEMIDI_ESP32_NimBLE>*)':
.pio/libdeps/esp32doit-devkit-v1/BLE-MIDI/src/hardware/BLEMIDI_ESP32_NimBLE.h:144:26: error: expected type-specifier before 'NimBLESecurity'
  144 |     auto _security = new NimBLESecurity();
      |                          ^~~~~~~~~~~~~~
.pio/libdeps/esp32doit-devkit-v1/BLE-MIDI/src/hardware/BLEMIDI_ESP32_NimBLE.h:145:38: error: 'ESP_LE_AUTH_BOND' was not declared in this scope
  145 |     _security->setAuthenticationMode(ESP_LE_AUTH_BOND);
      |                                      ^~~~~~~~~~~~~~~~
*** [.pio\build\esp32doit-devkit-v1\src\main.cpp.o] Error 1
@spDuchamp
Copy link

I can confirm I'm having the exact same problem, and when I roll back to version 2.1.0, the project compiles just fine.

@MicroMidi
Copy link
Contributor

MicroMidi commented Jan 28, 2025

May I ask if there will be a new official release of this brilliant library that leverages the features of the new major NimBLE 2.x.x version? Thanks in advance🙏

@lathoub
Copy link
Owner

lathoub commented Jan 28, 2025

Hi @MicroMidi et al - good question. An official release of this library is difficult, as it relies on calls in the underlying MIDI library that have not been rolled up in a release. It has been in the air for a while, but we (@FortySevenEffects (*) and myself) have to organize a 'release party' to align all the releases of the libraries again (the base libraries and all the derived protocols). Maybe this is a good trigger for a concerted effort.

@MicroMidi
Copy link
Contributor

Hi @lathoub,
thank you for your reply. I wasn't aware of all the dependencies that need to be considered in order to have the furious “release party”. It would be really great to have an updated state of the art BLE-MIDI library, as the hard work you and the other library owners have put into developing these libraries will be carried into the future. Right now, users have to struggle with different library versions to find a solution that works for their project. And I'm pretty sure your user base is quite large.

Thanks again for your hard work and for your great contribution to the Arduino ESP32 community

Bernd

@lathoub
Copy link
Owner

lathoub commented Feb 2, 2025

Problem fixed in master branch.
but... I do not have hardware to test for the moment, so please test for me!

the main security settings are

NimBLEDevice::setSecurityAuth(true, false, false);

parameters described here:

Please let me know if this fix works

@lathoub lathoub added the help wanted Extra attention is needed label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants