New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor plugin dependencies and automatically handle them instead of using weights #33

Open

davidferlay opened this issue Mar 1, 2024 · 0 comments

Contributor

davidferlay commented Mar 1, 2024 •

edited

Loading

Observed

Plugins loading is currently handled manually and by weight order
That can lead to concurency / race condition for resolving dependencies
add plugin weight to fix keyring service dependency skilld-labs/plasmactl-publish#4 (comment)

Expected

Introduce a more robust dependency system which does not rely on weighted plugins

launchr/internal/launchr/types.go

Line 50 in a1e4399

// Weight defines the order of plugins calling. @todo rework to a real dependency resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment