-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: 'Show More' Button Misalignment and Missing on Revisit #4862
Comments
@MisRob The issue #4838 (Hotfixes - Import from other channels - The 'Show more' button is not centered) was assigned to me. While working on it, I noticed there were additional related problems, so I opened a new issue to address them. As I'm interested in contributing to both, I started working on resolving these issues together to ensure a complete fix. |
Hey @jayesh9747. I will assign this to you. However, It will be great if you can solve #4838 first an then come to this later. Also, after reading this issue description + all the conv that we have already had in #4838, I suspect you have misunderstood the #4838 issue description. That button is actually centered. The more button that is not centered is the one you can see when you are Importing from other channels, as you can see the image that Peter attached in the #4838 issue description: If you look at it closely you will notice a couple of things:
So looking at it closely should suggest that probably you are not in the right page. And I take the time to write all this to note that one should be humble and accept that we can all have misunderstandings, and that maybe even if the issue is just about centering a button, we need some time to really understand what the issue is asking for and understand how to replicate it. And with this, we must refrain from saying things like "I don’t think this issue should take three weeks to fix. Can I start working on it now? I can complete it within a day." which in some way could feel like you are belittling the other contributor. Specifically, this was not the case because the other contributor had actually abandoned it, but in any case we should say things with more humility :). (In the end you didn't end up solving it in one day (and its okay), and not because you didn't have the technical skills to do it, but because by doing it quickly you didn't make sure you understood 100% of what the issue was asking for). I hope this is helpful. And I wish you happy holidays 👐. And also wanted to let you know that we will be closed from December 23 to January 5. |
@AlexVelezLl, thank you for your advice. I will definitely follow the path you suggested. Once again, thank you! I deeply resonate with your answer. |
I'm working on this issue where the "Show More" button misalignment and missing on revisit happens. It works fine in the local development environment, but in production, it's not working properly. I thought it might be an API response issue, but the response should be correct and consistent in both environments. I've attached some console screenshots. Screencast.from.04-01-25.10.39.25.PM.IST.webmProduction ENV: Screencast.from.04-01-25.10.46.00.PM.IST.webmIn there production Enviorment there api resone have showmore Object but there is no show more button. Can you help me figure out what might be causing this and suggest how to tackle it? |
Hey @jayesh9747! Could you provide more context about when is this happening? I am being able to see the show more button in the prod env, so perhaps is an edge case. |
Hello, @AlexVelezLl, Whenever I go to: https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in. I have shared a demo video above. Could you revisit the same resource page and check whether you're able to see the "Show More" button? |
Also provide differnt browser(brave) demo vedio Screencast.from.07-01-25.09.00.26.AM.IST.webmsee in this vedio whenever i go leval 4 first time i am able to see the show more button but when i revisit same leval for show more button vanished. |
Oh okay, I get it, although this is the bug this issue is reporting. We need to find a way of how can we solve it in unstable first. |
@AlexVelezLl can you guide me from where i can start to find out this ? and please tag me whenever you reply so that i will get notification, thank you. |
name: Pagination 'show more button issue'
about: Report a bug to help us improve
title: "[Bug]: 'Show More' Button Misalignment and Missing on Revisit"
Observed behavior
On the first visit, the 'Show More' button is not centered.
Screenshot:
On revisiting the same page:
In Level 2, there are 35 resources available. However:
Expected behavior
User-facing consequences
Errors and logs
No errors or logs observed.
Additional information
Steps to reproduce the issue
Usage Details
The text was updated successfully, but these errors were encountered: