Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove contactsPresent field from Registration type #7920

Open
aarongable opened this issue Jan 7, 2025 · 0 comments · May be fixed by #7952
Open

Remove contactsPresent field from Registration type #7920

aarongable opened this issue Jan 7, 2025 · 0 comments · May be fixed by #7952
Assignees
@jprenken

Comments

@aarongable
Copy link
Contributor

Now that we are using separate gRPC methods to update various fields (contacts, status, key) of a Registration, we no longer need the contactsPresent field. Remove it, and all code which reads/writes it (in that order).
@jprenken jprenken mentioned this issue Jan 11, 2025
Merged
@jprenken jprenken self-assigned this Jan 11, 2025
jprenken added a commit that referenced this issue Jan 14, 2025
@jprenken @jsha
ra, pb: Don't expect or validate contactsPresent (#7933)
7da9a83 
Part of #7920

There will be a followup removing the remaining places that set
`contactsPresent`.

---------

Co-authored-by: Jacob Hoffman-Andrews <[email protected]>
@jprenken jprenken linked a pull request Jan 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jprenken jprenken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: Remove contactsPresent from Registration letsencrypt/boulder
2 participants
@aarongable @jprenken