Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binaries for newer versions of libgit2? #110

Closed
tompazourek opened this issue Nov 14, 2020 · 7 comments
Closed

Binaries for newer versions of libgit2? #110

tompazourek opened this issue Nov 14, 2020 · 7 comments

Comments

@tompazourek
Copy link

The latest version of libgit2sharp.nativebinaries NuGet package contains binaries for the version 0.28.0 of libgit2. However, there have been many releases since:

  • 0.28.1
  • 0.28.2
  • 0.28.3
  • 0.28.4
  • 0.28.5
  • 0.99.0
  • 1.0.0
  • 1.0.1
  • 1.1.0

They contain some useful fixes that would be nice to have. Are there any plans to publish binaries for these newer versions?

Thanks

@DvdKhl
Copy link

DvdKhl commented Jun 12, 2021

I'm also wondering if there is a particular reason why it isn't updated to a newer version.

I've cloned both repositories libgit2sharp and this one, made a few changes to get it running with net5 and Visual Studio 2019.
Then I've updated/compiled/packaged this repo to use the source of libgit2 1.1.0 with the provided scripts.

Then I ran the tests in LibGit2Sharp.Tests (which uses the new binary package) and only 5 tests failed:
image

I think it would be nice to have an additional nuget alpha preview release of libgit2sharp with the 1.1.0 binaries, so more people are able to test it.

@rgl
Copy link

rgl commented Jun 15, 2021

This now seems to be available at:

But it seems there is no one looking at this project anymore :-(

@jairbubbles
Copy link
Contributor

@DvdKhl With the package produced by #114 I was able to run all tests successfully with only a few minor changes. "origin/HEAD" is now added when cloning (see libgit2/libgit2#5651) and some tests are failing because they are counting the branches after clone.

I didn't have any issue with CanGetBlobAsTextWithVariousEncodings or NoPublicTypesUnderLibGit2SharpCoreNamespace.

I will create a PR but I need to reference the new package which is not on nuget.org for the CI to pass.

@bording
Copy link
Member

bording commented Aug 21, 2021

@jairbubbles #114 has been merged, and I've published 2.0.315-alpha.0.1 with the changes.

@jairbubbles
Copy link
Contributor

Looks awesome to me!

@jairbubbles
Copy link
Contributor

I create a draft PR here in libGit2Sharp => libgit2/libgit2sharp#1905

@bording
Copy link
Member

bording commented Sep 15, 2021

Since we now have packages up on nuget.org with newer versions, I'm going to go ahead and close this.

@bording bording closed this as completed Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants