Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stream::Shared to use internal mutability #170

Open
thomaseizinger opened this issue Jul 20, 2023 · 3 comments · May be fixed by #197
Open

Refactor stream::Shared to use internal mutability #170

thomaseizinger opened this issue Jul 20, 2023 · 3 comments · May be fixed by #197
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thomaseizinger
Copy link
Contributor

Currently, we hold a stream::Shared within the stream and one in Active. This is shared by being wrapped in Arc<Mutex>.

It would be slightly more ergonomic for both usage sites if the Arc<Mutex> would be inside stream::Shared.

@thomaseizinger thomaseizinger added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 20, 2023
@akaladarshi
Copy link

Hey @mxinden

Is this issue still available for pickup?

@dariusc93
Copy link
Member

Yes it is @akaladarshi :)

@akaladarshi
Copy link

akaladarshi commented Jan 22, 2025

@dariusc93 Can you assign it to me?.

Also just to get the full idea: We need to put Arc<Mutex> inside stream::Shared, so we don't have to use Arc<Mutex<Shared>> everywhere else.

@akaladarshi akaladarshi linked a pull request Jan 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants