Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links if value contains backslash #5

Open
cyco opened this issue May 19, 2023 · 0 comments
Open

Broken links if value contains backslash #5

cyco opened this issue May 19, 2023 · 0 comments

Comments

@cyco
Copy link

cyco commented May 19, 2023

Hi,

I noticed that db.libretro.com sometimes interprets backslashes as directory separators and generates invalid links. You can take a look at https://db.libretro.com/Sony%20-%20PlayStation/Alundra%20(USA).html where the linked developer page is invalid. The linked page is https://db.libretro.com/developer/Matrix%20Software%20/Contrail.html but should be https://db.libretro.com/developer/Matrix%20Software%20%5CContrail.html.

I think \ should be added to scrubIllegalChars in https://github.com/libretro/webdb/blob/master/main.go#LL26C3-L26C3

Edit: https://stackoverflow.com/a/10444621 suggests \ in urls are invalid and browsers are trying to do some error recovery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant