Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: SDLActivity being an activity prevents activities from inheriting other classes #11890

Open
isXander opened this issue Jan 8, 2025 · 3 comments
Milestone

Comments

@isXander
Copy link
Contributor

isXander commented Jan 8, 2025

In an android project I am trying to implement SDL into, activities extend from AppCompatActivity. An android-provided abstract activity to backport newer features to older API levels.

This prevents the use of SDLActivity, since OOP demands exactly one parent class.

The SDLActivity should be adapted to be composable onto existing activities, instead of relying on inheritance.

@isXander isXander changed the title SDLActivity being an activity prevents activities from inheriting other classes Android: SDLActivity being an activity prevents activities from inheriting other classes Jan 8, 2025
@slouken
Copy link
Collaborator

slouken commented Jan 8, 2025

Feel free to create a PR.

@slouken slouken added this to the 3.x milestone Jan 8, 2025
@isXander
Copy link
Contributor Author

isXander commented Jan 8, 2025

Feel free to create a PR.

How much complexity are you willing to add here though? I can keep backwards compatibility with an extendable SDLActivity.

@slouken
Copy link
Collaborator

slouken commented Jan 8, 2025

Feel free to create a PR.

How much complexity are you willing to add here though? I can keep backwards compatibility with an extendable SDLActivity.

If you can do that, it should be fine. SDL 3.2 is close enough that the Java code should be stable for changes, and if you do it soon, we can get it in for 3.2.0 which marks the point at which we wouldn't want to make big changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants